Conversation
zzylol
changed the base branch from
main
to
refactor/query-plan-dag-execution
September 22, 2026 20:20
This was referenced Sep 22, 2026
This was referenced Sep 22, 2026
zzylol
changed the base branch from
refactor/query-plan-dag-execution
to
perf/issue-758
September 22, 2026 20:45
This was referenced Sep 23, 2026
This was referenced Sep 23, 2026
zzylol
force-pushed
the
perf/issue-758
branch
from
September 24, 2026 12:55
4530670 to
999cafd
Compare
zzylol
changed the base branch from
perf/issue-758
to
refactor/query-plan-dag-execution
September 24, 2026 12:56
zzylol
force-pushed
the
refactor/query-plan-dag-execution
branch
from
September 26, 2026 04:42
90154af to
6a9dc9c
Compare
This was referenced Sep 26, 2026
…nd SDS Adopt the Planner #462 physical candidates and typed persistence codecs. Install native TopK, Rate heap and grouped Sum programs, run native maintenance over durable counter SDS, and recover bound outputs by output identity and window range without re-lowering operators. Bind Planner candidate forests to deployment candidates, accept scoped accuracy evidence (quantile domains, TopK separation), check composed query accuracy before admission, and scope SDS definitions and cost manifests to the logical dataset. Candidates are still selected by complete provider quotes; ERP/analytical costing is a separate change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Candidate tests cover accuracy rejection, quote-driven exact/CMS/ CountSketch selection and both physical graphs. Real-process tests cover counter/heap SDS through HTTP and restart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closing as superseded by #788, which installs, executes and recovers the same native candidates (same test names in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native candidates over dataset-bound SDS
Backend admits, installs and recovers Planner's native physical candidates, binds them to dataset-scoped SDS, and accepts scoped accuracy evidence. Candidates are still selected by complete provider quotes. ERP and analytical workload costing were split into #786, which follows #728.
Stack: main → #763 → #765 → #761 → #728 → #786 → #780 → #742 → #775. Controls #766 branch from #761; diagnostics #756 branch from #786.
Before this PR
Native TopK computations and stored-state maintenance boundaries did not consistently survive deployment installation and recovery. Accuracy facts could not be scoped to one query, data population and snapshot, so heap and ratio candidates could not be certified.
After this PR
For
topk by(job)(1, rate(requests_total[1m])), Planner supplies exact ranking, query-time CMS/CountSketch heap, and fixed-window precomputed heap candidates. Backend binds counter or heap SDS and preserves the supplied operators. The precompute candidate buffers complete timestamped counter states, finalizes each series' Rate, builds a fresh heap, and stores it; query execution reads that heap. It never adds finalized rates across windows.For
sum by(job)(rate(requests_total[1m])), Planner also supplies query-time Sum and precomputed Sum. Both finalize Rate per series before grouping. Complete 60-second windows may overlap at a five-second evaluation cadence; each window is an independent result.Spatial TopK supports native exact ranking and signed CountSketch heap over the complete current-series snapshot. Arbitrary signed values do not authorize CMS.
Scoped accuracy evidence (quantile operand domains, TopK separation bounds) is bound to the query, data workload, snapshot and validity window. Missing proof leaves a candidate visible but not admissible; composed results (for example a quantile ratio) must satisfy the root accuracy target, not only leaf guarantees.
Installed query and maintenance programs retain typed boundaries. Bound SDS reads validate deployed output and semantic definition, window, generation, encoding and schema. SDS definitions and cost manifests carry the logical dataset identity, so quotes cannot be reused across dataset scopes. Manifests include maintenance programs as well as query programs. Recovery does not re-lower the physical operators.
Validation and scope
--test-threads=1): all targets pass except threeasapquery_compatibility_process_e2etests (two backend-readiness timeouts andissue_701_702_uncertified_ratios_require_exact_fallback). They fail identically on the pre-split feat: install, execute and recover native candidates over dataset-bound SDS #761 head withASAP_TEST_TIMEOUT_SCALE=4, so the split did not introduce them. Strict all-target Clippy and rustfmt pass.Without
workload_cost_evidence, deployment still requires complete quotes, as on the base. Automatic ERP/analytical costing, HLL confidence contracts and ERP accuracy admission are in #786.Planner #462 pin:
176c1bd565e0c400f9a35996c2bd65de32475e72.Closes #752. See
docs/design_docs/evidence-dependent-candidates.mdanddocs/design_docs/summary-catalog-sds-architecture.md.🤖 Generated with Claude Code